Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method put failing on junctions #4743

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Fix method put failing on junctions #4743

merged 1 commit into from
Jan 30, 2022

Conversation

vrurg
Copy link
Member

@vrurg vrurg commented Jan 29, 2022

Resolves #4742. Aside of plain throwing (1|2).put also fix recursive cases when a junction is an eigenstate of another junction.

Resolves rakudo#4742. Aside of plain throwing `(1|2).put` also fix recursive
cases when a junction is an eigenstate of another junction.
@lizmat
Copy link
Contributor

lizmat commented Jan 29, 2022

What's so special about put? What not also say and print ?

@vrurg
Copy link
Member Author

vrurg commented Jan 29, 2022

Because say and note do gist and it doesn't autothread. print works because it falls back to $*OUT.printwhich just autothreads.

But put is about Str and it uses nqp::concat. So, nqp::concat fails when it gets a Junction instance from .Str.

@vrurg vrurg merged commit ba4d233 into rakudo:master Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

put method fails to print junctions
2 participants