Make push and unshift iterate on single arguments in containers. #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per http://irclog.perlgeek.de/perl6/2015-08-24#i_11106557 itemization only protects against flattening, not single-arg-rule. When push and shift were implemented they assumed the opposite. This brings their behavior in line and fixes as much of the fallout from that in rakudo. Even with those fixes we lose progress on the test suite -- 7 files and some more tests in already failing files need adjustment because they relied on the previous behavior. Some of the internal fixes may be superstitious, but can be cleaned up later (you must be able to know you will not get any Iterables to determine what is safe, and that is time consuming.)
|
GLRR removed the need for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per http://irclog.perlgeek.de/perl6/2015-08-24#i_11106557
itemization only protects against flattening, not single-arg-rule.
When push and unshift were implemented they assumed the opposite.
This brings their behavior in line and fixes as much of the
fallout from that in rakudo. Even with those fixes we lose
progress on the test suite -- 7 files and some more tests in
already failing files need adjustment because they relied on
the previous behavior.
Some of the internal fixes may be superstitious, but can be
cleaned up later (you must be able to know you will not get any
Iterables to determine what is safe, and that is time consuming.)