Add runtime dependencies net/http #67
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoryu
requested changes
Jan 22, 2017
| @@ -17,6 +17,8 @@ Gem::Specification.new do |spec| | |||
| spec.require_paths = ["lib"] | |||
| spec.required_ruby_version = '>= 2.1.0' | |||
|
|
|||
| spec.add_runtime_dependency 'net' | |||
There was a problem hiding this comment.
これはTwitter関連のgemだと思うのですが、必要なんでしょうか？
| @@ -1,6 +1,7 @@ | |||
| module RakutenWebService; end | |||
| RWS = RakutenWebService | |||
|
|
|||
| require 'net/http' | |||
There was a problem hiding this comment.
実際にnet/httpを利用するのは、RWS::Client 内なので、lib/rakuten_web_service/client.rb に移した方が関係が明確になって良いかと思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
実行時の
uninitialized constant RakutenWebService::Client::Net (NameError)エラーを修正します参照: Ruby - Rubyプログラムの楽天APIのNameError(62804)｜teratail