Dirs #46
Merged
Dirs #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakyll
reviewed
Aug 6, 2018
README.md
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| [](https://travis-ci.org/rakyll/statik) | |||
|
|
|||
| This is a fork of github.com/rakyll/statik - I wanted working Readdir. | |||
fs/walk.go
Outdated
| @@ -0,0 +1,97 @@ | |||
| // Copyright 2018 Tamás Gulácsi. All Rights Reserved. | |||
There was a problem hiding this comment.
Revert the license header to the previous.
There was a problem hiding this comment.
This file is totally new, but I don't object.
fs/walk.go
Outdated
| "path" | ||
| ) | ||
|
|
||
| var SkipDir = errors.New("skip dir") |
There was a problem hiding this comment.
What about using filepath.SkipDir?
I copied filepath.WalkFunc and filepath.SkipDir, you suggested just referencing it - keep it consistent, and use filepath.SkipDir.
fs/walk.go
Outdated
| // Walk skips the directory's contents entirely. | ||
| // If the function returns SkipDir when invoked on a non-directory file, | ||
| // Walk skips the remaining files in the containing directory. | ||
| type WalkFunc func(path string, info os.FileInfo, err error) error |
There was a problem hiding this comment.
What about just using filepath.WalkFunc instead of introducing this type?
- remove "fork" comment from README - revert change of licensing in fs/walk.go - fix fs/ tests for directories.
Merged
rakyll
pushed a commit
that referenced
this pull request
Nov 28, 2018
ekanna
pushed a commit
to ekanna/statik
that referenced
this pull request
Sep 12, 2019
ekanna
pushed a commit
to ekanna/statik
that referenced
this pull request
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add directories and ReadFile.