Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master for Go < 1.10 #54

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Fix master for Go < 1.10 #54

merged 1 commit into from
Nov 28, 2018

Conversation

Keats
Copy link
Contributor

@Keats Keats commented Oct 3, 2018

A recent patch (#46) broke go get using versions of Go older than 1.10 as it is
using the newly introduced FileHeader.Modified

This patch replaces the .Modified by a call to the deprecated SetModTime to maintain compatibility.

Fix #50

A recent patch broke (rakyll#46) broke go get
using versions of Go older than 1.10 as it is
using the newly introduced FileHeader.Modified

This patch replaces the .Modified by a call to the
deprecated SetModTime to maintain compatibility.

Fix rakyll#50
@Keats Keats mentioned this pull request Oct 4, 2018
@Keats
Copy link
Contributor Author

Keats commented Oct 23, 2018

@rakyll any chance this can be merged? This is blocking a couple of projects still on Go <1.10 that are currently using my fork

@rakyll rakyll merged commit 7925817 into rakyll:master Nov 28, 2018
ekanna pushed a commit to ekanna/statik that referenced this pull request Sep 12, 2019
A recent patch broke (rakyll#46) broke go get
using versions of Go older than 1.10 as it is
using the newly introduced FileHeader.Modified

This patch replaces the .Modified by a call to the
deprecated SetModTime to maintain compatibility.

Fix rakyll#50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants