Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate everything to @testing-library #1440

Closed
kennethnym opened this issue Oct 11, 2022 · 0 comments · Fixed by #1447
Closed

Migrate everything to @testing-library #1440

kennethnym opened this issue Oct 11, 2022 · 0 comments · Fixed by #1447
Assignees
@kennethnym
Labels
enhancement New feature or request

Comments

@kennethnym
Copy link
Member

Description:
Migrate all unit tests to use @testing-library to allow React 18 upgrade.

Acceptance criteria:

  • All the tests are using @testing-library and coverage remains the same.
@kennethnym kennethnym added the enhancement New feature or request label Oct 11, 2022
@kennethnym kennethnym self-assigned this Oct 11, 2022
This was referenced Oct 18, 2022
Open
Open
Open
@kennethnym kennethnym mentioned this issue Oct 21, 2022
Merged
3 tasks
@kennethnym kennethnym linked a pull request Oct 21, 2022 that will close this issue
Migrate every test to use testing-library #1447
Merged
3 tasks
@louise-davies louise-davies mentioned this issue Feb 10, 2023
Closed
2 tasks
@jounaidr jounaidr mentioned this issue Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kennethnym kennethnym

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate every test to use testing-library ral-facilities/datagateway
1 participant
@kennethnym