This repository has been archived by the owner on May 9, 2020. It is now read-only.
Scaffolding fixes #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use same namespace in FbDesignTimeServices as everywhere else * add FbOptions to serviceCollection in FbDesignTimeServices
* handle indices without fields * handle tables without PK * fix nullable columns (NULL switched with NOT NULL) * better foreign key detection
After changing Book<->Author relation to many-to-many, inserted items count changed.
|
There is something breaking the test, the Author Column was not found! I'll see what's going on. |
Repository owner
deleted a comment from
AppVeyorBot
Jun 23, 2018
Repository owner
deleted a comment from
AppVeyorBot
Jun 23, 2018
Repository owner
deleted a comment from
AppVeyorBot
Jun 23, 2018
Repository owner
deleted a comment from
AppVeyorBot
Jun 23, 2018
Repository owner
deleted a comment from
AppVeyorBot
Jun 23, 2018
Repository owner
deleted a comment from
AppVeyorBot
Jun 23, 2018
xunit allows different test classes to run in parallel, which caused file access errors on TestContext
1 similar comment
|
There were some file access issues with "EFCoreSample.fdb", I changed the new class to use a different file name. |
|
@qbikez Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and tests for DbContext scaffolding.
I see most of the changes are already included in the source, but I also added some tests for verifying generated context.