Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PAGE_SIZE = 0MB in AppendAlloc #120

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Use PAGE_SIZE = 0MB in AppendAlloc #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92f357b
Use PAGE_SIZE = 0MB in AppendAlloc
jfowkes Jul 3, 2023
1f25266
Comment on setting PAGE_SIZE = 0MB
jfowkes Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/ssids/cpu/AppendAlloc.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace spral { namespace ssids { namespace cpu {
namespace append_alloc_internal {

/** A single fixed size page of memory with allocate function.
* We are required to guaruntee it is zero'd, so use calloc rather than anything
* We are required to guarantee it is zero'd, so use calloc rather than anything
* else for the allocation.
* Deallocation is not supported.
*/
Expand Down Expand Up @@ -65,7 +65,9 @@ private:
* Deallocation is not supported.
*/
class Pool {
const size_t PAGE_SIZE = 8*1024*1024; // 8MB
const size_t PAGE_SIZE = 0; // 0MB
// Changed to 0MB to allow pages of no minimum size for performance
// see https://github.com/ralna/spral/issues/119 for more details
public:
Pool(size_t initial_size)
: top_page_(new Page(std::max(PAGE_SIZE, initial_size)))
Expand Down