Use PAGE_SIZE = 0MB in AppendAlloc #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjacobse
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Seems good to me, thanks. Maybe a short comment in the code for why PAGE_SIZE even exists could be helpful, now that it does not really do anything in the max expressions anymore with a value of 0. Perhaps just referencing the issue #119 could work?
jfowkes
deleted the
119-large-minimum-allocation-size-in-appendalloc-for-ssids-factor-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #119 by setting PAGE_SIZE = 0MB in AppendAlloc.