Fix TypeError in str(TaskwarriorError(...)) #126
Conversation
`__str__` should return a string, but `string.encode(...)` returns bytes instead. This commit fixes it by decoding the bytes back to a string. Fixes: ralphbean#125
|
@ralphbean Ping |
| @@ -18,4 +18,4 @@ def __unicode__(self): | |||
| ) | |||
|
|
|||
| def __str__(self): | |||
| return self.__unicode__().encode(sys.getdefaultencoding(), 'replace') | |||
| return self.__unicode__().encode(sys.getdefaultencoding(), 'replace').decode(sys.getdefaultencoding()) | |||
There was a problem hiding this comment.
Just briefly glancing, I’m fairly sure this is here from when we were supporting Python 2.7 where this method had to return bytes (& I believe we’ve dropped that by now).
Rather than calling __unicode__, encoding to bytes, then decoding once again, we should really probably just move the contents of __unicode__ here and delete the __unicode__ method entirely.
There was a problem hiding this comment.
FYI - did this as part of #149
|
Hi, I've come across this error while using another tool for syncing tasks. Has this ever been merged? |
|
This wasn't, no, @mcrot, but given that Python 2.7 has been unsupported for quite a while now, this should probably be fixed such that we don't go through the hoops of trying to handle both |
|
@coddingtonbear could you take a look at #149 - it includes this change among few other python2 cleanups. Let me know if you'd prefer to split it. |
|
Fixed via #149! Apologies for the back-and-forth on all of this, but I believe this error is now behind us. |
__str__should return a string, butstring.encode(...)returns bytes instead. This commit fixes it by decoding the bytes back to a string.Fixes: #125