Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding notification for video download and video download unsuccessfull #739

Open
okan35 opened this issue Apr 13, 2020 · 1 comment
Open

Comments

@okan35
Copy link
Contributor

okan35 commented Apr 13, 2020

I downloaded video butnobnotification was given for download progress or if it even started downloading as in the end it gave error and said it couldn't download.

Device is sony xperia xz premium and version of OS is Android 9

I found out that using adblocker inteferes with download manager. Not sure how to go around this other than somehow whilelisting skytube from adblocker app, but definitely would like if somehow we could detect this internally. I could not quiet catch an error from download manager.

On the other hand newpipe is not effected by this. It downloads while blokada is on and adguard dns is on.

issue is here from blokada as I use blokada
blokadaorg/blokada#324

@okan35 okan35 changed the title Adding notification for video download Adding notification for video download and video download unsuccessfull Apr 13, 2020
@gzsombor
Copy link
Member

Interesting. NewPipe has a huge, internal download manager - which is forked from an other codebase ( https://github.com/TeamNewPipe/NewPipe/tree/dev/app/src/main/java/us/shandian/giga ), that's why it's probably not affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants