Fix index overflow issue in examples #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In both receiveEvent and requestEvent, reg_position overflows one unit early due to a greater-than-or-equal comparison with reg_size_lessone. The solution is either to retain the comparison operator but eliminate reg_size_lessone, or to change the comparison to greater-than and retain reg_size_lessone. I have chosen to eliminate reg_size_lessone, as it is clumsy to store a (variable - 1) in a separate variable.
In both receiveEvent and requestEvent, reg_position overflows one unit early due to a greater-than-or-equal comparison with reg_size_lessone. The solution is either to retain the comparison operator but eliminate reg_size_lessone, or to change the comparison to greater-than and retain reg_size_lessone. I have chosen to eliminate reg_size_lessone, as it is clumsy to store a (variable - 1) in a separate variable.
In both receiveEvent and requestEvent, reg_position overflows one unit early due to a greater-than-or-equal comparison with reg_size_lessone. The solution is either to retain the comparison operator but eliminate reg_size_lessone, or to change the comparison to greater-than and retain reg_size_lessone. I have chosen to eliminate reg_size_lessone, as it is clumsy to store a (variable - 1) in a separate variable.
|
Yeah, I got this nasty feeling that the modulo I was using earlier would be expensive and then obviously had some brainfart when fixing that... |
rambo
added a commit
that referenced
this pull request
Jun 7, 2014
Fix index overflow issue in examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All three examples contained a bug where the reg_position index overflows too early due to a greater-than-or-equal comparison to reg_size_lessone. One solution is to replace the greater-than-or-equal comparison operator with a greater-than operator. The better solution is to retain the >= operator, but to remove entirely the reg_size_lessone variable. It is somewhat clumsy to store as a separate variable another variable that has been decremented by one.