Convert publish.js to Ramda functions #133
Conversation
| ) | ||
| ), | ||
| R.flatten | ||
| ) |
There was a problem hiding this comment.
Here's a simpler version:
// simplifySee :: Array String -> Array String
var simplifySee =
R.pipe(R.chain(R.split(/\s*,\s*/)),
R.map(R.replace(/^R[.]/, '')));There was a problem hiding this comment.
Nice, thanks!
Updated PR.
| var prettifyCode = R.pipe( | ||
| R.join('\n'), | ||
| R.replace(/^[ ]{5}/gm, ''), | ||
| R.flip(R.invoker(2, 'highlight')('javascript'))(hljs), |
There was a problem hiding this comment.
I'd find this clearer:
function(s) { return hljs.highlight('javascript', s); }There was a problem hiding this comment.
Yeah, I did have mixed feelings about that code.
I've used a fat arrow instead, hope that's still fine.
There was a problem hiding this comment.
If we're to use a fat arrow here, why not throughout the file? While we're at it we could replace occurrences of var with const. :)
There was a problem hiding this comment.
Quick find-replace, no problems!
I had just wanted to make sure ES6 was fine first.
|
I left one more comment, but this looks great! |
|
Is this all good now? |
|
i haven't found time to run it locally yet, but if it passed the gauntlet of @davidchambers review, i would expect it's good |
|
LGTM |
|
🐄 |
No description provided.