Fixed interference of css style from docs page to repl #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the css class name and selector for docs more selective to avoid messing up with the .repl class in the repl
1 task
|
ping reviewers |
|
I'm happy to look this over, but I'm not sure if I have reviewing powers |
|
This certainly LGTM |
|
sorry i have been totally buried lately. will try to look over the weekend, please ping me again if you have heard nothing by sunday |
|
@buzzdecafe ping ping |
|
thanks for your patience 🐄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #190 (comment), the PUG based template has some minor styling issue on the repl. This is due to the over-general css class
.replintroduced in https://github.com/ramda/ramda.github.io/pull/185/files#diff-e73ad0a6a3cca0e9ce1279bf47761a0eR45. That PR itself is fine becauserepl/index.htmldid not includestyle.css. But when the PR https://github.com/ramda/ramda.github.io/pull/175/files#diff-8ca7384ffd04b23fb9f8dde4473e055fR14 refactored the repl index.pug template to inherit the samelayout.pugwhich includesstyle.css, the interference of the css style takes effect.This PR made the css class name and selector for docs more selective to avoid messing up with the
.replclass in the repl.I re-generated
style.css, but not sure if I should update the one in0.24.1folder or anywhere else.@MattMS @tolmasky @buzzdecafe