Update _xfind to transducer protocol #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this mean this function is not invoked by the test suite? |
|
I don't think so. As I noted in #1007 it appears to me as if most of the transducer functions are untested. If I'm right there should probably be a discussion about the general approach to testing these functions (I used And note that the commit by @buzzdecafe I linked to above doesn't change any tests either. |
|
whoops. yes, i broke it, and yes, we need coverage |
buzzdecafe
added a commit
that referenced
this pull request
Apr 10, 2015
Update _xfind to transducer protocol
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is seems like this commit missed this
initfunction in_xfind.