-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate TS definitions #1999
integrate TS definitions #1999
Conversation
This PR would integrate TypeScript definitions based on my fork of @donnut's
|
I have no competence in this area. Is there someone who feels up to a review? @donnut? @arcseldon? Someone else? |
Extra considerations:
|
Having talked to @donnut a bit further, the versioning point is one we both consider a concern. I imagine in a merged context, this might make for undue pressure toward Ramda, where releases are a bit more formal, involving full copies of the documentation for users of previous versions. With that in mind, perhaps the most elegant path would be for us not to merge in, but to continue supporting users of Ramda + TypeScript without otherwise getting in your way. Might this line of thinking align with your views @CrossEye? |
That might make the most sense. It's probably the easiest way to start out. If we want to alter this later, we could always consider adding point-releases if it needed to change between Ramda versions. My larger versioning concern is actually in the other direction. I just started pulling together a new version for Ramda itself. They don't happen (at least yet) on any regular cadence. But I would not enjoy having to chase down maintainers of such things as this in order to have a complete release ready. Maybe that's the price of maturing, but it's not one I feel really ready to pay. |
Yeah, I feel you there, thanks for being straight-forward. |
No description provided.