add thrush combinator as applyTo #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bradcomp
reviewed
Oct 4, 2017
| @@ -15,6 +15,7 @@ export { default as aperture } from './aperture'; | |||
| export { default as append } from './append'; | |||
| export { default as apply } from './apply'; | |||
| export { default as applySpec } from './applySpec'; | |||
| export { default as applyTo } from './applyTo'; | |||
There was a problem hiding this comment.
Is this something we will need to add into our PRs in the future? Can we get a build script to do this?
There was a problem hiding this comment.
I was in favor of doing this automatically via a script when we first added an index.js file but we decided against it.. I think it is fine to do it manually as I believe in all cases (adding, moving, deleting functions) either tests or building will fail if index.js is not updated.
There was a problem hiding this comment.
It may be worth it at this point to update the instructions in CONTRIBUTING.md
|
🐄 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1846, #1847