Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved viewfinder detection #307

Merged
merged 1 commit into from
May 23, 2024
Merged

Improved viewfinder detection #307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions addons/phantom_camera/scripts/panel/viewfinder/viewfinder.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,24 +165,46 @@ func _settings_changed() -> void:
camera_viewport_panel.size.x = viewport_width / (viewport_height / sub_viewport.size.y)
# TODO - Add resizer for Framed Viewfinder


func _node_added_or_removed(_node: Node) -> void:
visibility_check()


func visibility_check() -> void:
if not viewfinder_visible: return

var phantom_camera_host: PhantomCameraHost
var has_camera: bool = false
if not PhantomCameraManager.get_phantom_camera_hosts().is_empty():
has_camera = true
phantom_camera_host = PhantomCameraManager.get_phantom_camera_hosts()[0]

var root: Node = EditorInterface.get_edited_scene_root()

if root is Node2D:
var camera_2d: Camera2D

if has_camera:
camera_2d = phantom_camera_host.camera_2d
else:
camera_2d = _get_camera_2d()

_is_2d = true
is_scene = true
_add_node_button.set_visible(true)
_check_camera(root, _get_camera_2d(), true)
_check_camera(root, camera_2d, true)
elif root is Node3D:
var camera_3d: Camera3D

if has_camera:
camera_3d = phantom_camera_host.camera_3d
else:
camera_3d = root.get_viewport().get_camera_3d()

_is_2d = false
is_scene = true
_add_node_button.set_visible(true)
_check_camera(root, root.get_viewport().get_camera_3d(), false)
_check_camera(root, camera_3d, false)
else:
is_scene = false
# Is not a 2D or 3D scene
Expand Down