[Backend] Feat: Movies Catalog #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramos-ph
reviewed
Dec 4, 2023
Comment on lines
+4
to
+8
| t.string :director | ||
| t.string :writer | ||
| t.string :title | ||
| t.string :producer | ||
| t.string :production_company |
There was a problem hiding this comment.
From this list, I think only title is not an array, yes? Let's leave this as it is and discuss this in another ticket.
Comment on lines
+42
to
+44
| def movie_not_found | ||
| render json: { error: "Movie not found" }, status: :not_found | ||
| end |
There was a problem hiding this comment.
We could use a Rails Concern to delegate the error handling.
ramos-ph
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO