Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RAMP npm package and upgrade build to Vite #450

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

yileifeng
Copy link
Member

@yileifeng yileifeng commented Jul 11, 2024

Related Item(s)

Closes #431, #381

Changes

  • [FEATURE] removed all RAMP build files and integrated RAMP through npm package
  • [BUILD] upgraded from Vue CLI to Vite build toolchain
  • [BUILD] moved all public folder files/assets to root
  • [BUILD] updated build configuration to support Vue plugin and NPM build in Vite
  • [BUILD] remove npm run update and the script used to fetch latest RAMP build files

Testing (in progress)

Everything RAMP and app related. Building for NPM package with Vite is still untested, I can build the dist contents properly with npm run build-plugin but will need to do a test version release to confirm everything is functional.


This change is Reviewable

Copy link

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 35 of 37 files at r1, 48 of 48 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

Copy link
Member

@dnlnashed dnlnashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 35 of 37 files at r1, 48 of 48 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 35 of 37 files at r1, 48 of 48 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

@yileifeng yileifeng merged commit 8539300 into ramp4-pcar4:main Jul 25, 2024
3 checks passed
@yileifeng yileifeng deleted the vite-npm-ramp branch July 25, 2024 19:03
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate with R4MP npm package
4 participants