Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing parameter from current_user_recently_played() #256

Merged
merged 4 commits into from
Sep 26, 2021

Conversation

marioortizmanero
Copy link
Collaborator

@marioortizmanero marioortizmanero commented Sep 25, 2021

Credits to @hellbound22 for the original PR: #198. I've rewritten it for the updated rspotify and applied the review comments.

Description

Fix the implementation of current_user_recently_played() with the missing parameters.

Motivation and Context

The Spotify web api of current_user_recently_played() has the parameters before and after that are not implemented in this crate.

Dependencies

None

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The OAuth2 test passes when adding the None as the second parameter. Might have to write another test when the Option is Some(_)

Also, been using this with success in a project of mine.

Please also list any relevant details for your test configuration

  • test_with_oauth::test_current_user_recently_played()

@marioortizmanero marioortizmanero changed the title Added missing parameter Added missing parameter from current_user_recently_played() Sep 25, 2021
src/clients/oauth.rs Outdated Show resolved Hide resolved
@ramsayleung ramsayleung merged commit f050940 into master Sep 26, 2021
@ramsayleung ramsayleung deleted the recently_played_after_v2 branch September 26, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants