Implement Default when it is possible to
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramsayleung
reviewed
Oct 8, 2021
| /// | ||
| /// [Reference](https://developer.spotify.com/documentation/web-api/reference/#endpoint-get-multiple-episodes) | ||
| #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Eq)] | ||
| #[derive(Deserialize)] |
There was a problem hiding this comment.
Is it ok to remove Clone, Debug, Serialize, PartialEq, Eq, because we have changed the declaration of this struct.
There was a problem hiding this comment.
Yes, this is just an intermediate model, so I've added the same derives as the rest of the intermediate models. We don't really expose it to the user, so Deserialize is enough.
ramsayleung
approved these changes
Oct 8, 2021
|
Everything looks good to me, except for one nitpick, that is it safe to implement |
|
What do you mean by "safe"? It should do no harm, it's just additional functionality wherever it's possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a
#[derive(Default)]where it is possible. I've also included a couple minor fixes, like renaming a model with a typo, or updating the docs of intermediate structs (i.e. holders ofVec<T>which are then simplified to just aVec<T>in the client).Motivation and Context
This closes #33 and leaves #223 and #221 as the only issues left for the new release :))
Dependencies
None
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tests still pass perfectly.