Added ParameterType::BINARY to UuidBinaryOrderedTimeType #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be added in |
ramsey
reviewed
Oct 29, 2021
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 60 61 +1
===========================================
Files 5 5
Lines 105 107 +2
===========================================
+ Hits 105 107 +2
|
Ocramius
suggested changes
Nov 5, 2021
| @@ -12,6 +12,7 @@ | |||
|
|
|||
| namespace Ramsey\Uuid\Doctrine; | |||
|
|
|||
| use Doctrine\DBAL\ParameterType; | |||
There was a problem hiding this comment.
Overall fine to have this patch, but then we need to bump the minimum supported doctrine/dbal to ^3.
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…eckout-3 Bump actions/checkout from 2 to 3
ramsey
pushed a commit
that referenced
this pull request
Dec 20, 2022
|
Thank you for contributing! 🎉 Apologies on the lengthy delay. I've committed this change in 41cfa5f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding this method, we allow Doctrine to set appropriate type for binding UUID parameters in queries. Otherwise they are bound as
ParameterType::STRINGby default. The default approach works in MySQL, but does not in Sqlite, when e.g. running functional tests.