Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ParameterType::BINARY to UuidBinaryOrderedTimeType #72

Closed
wants to merge 7 commits into from
Closed

Added ParameterType::BINARY to UuidBinaryOrderedTimeType #72

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
315c3cb
Added ParameterType::BINARY to UuidBinaryOrderedTimeType
ksowa Feb 28, 2019
cb06acf
Merge branch 'main' into master
ramsey Oct 26, 2021
360ed54
Update tests/UuidBinaryOrderedTimeTypeTest.php
ramsey Oct 29, 2021
c7f8897
Merge branch 'ramsey:main' into master
ksowa Mar 25, 2022
1cee7f1
Bump actions/checkout from 2 to 3
dependabot[bot] Mar 25, 2022
3046b74
Merge pull request #1 from ksowa/dependabot/github_actions/actions/ch…
ksowa Mar 25, 2022
7ca73fd
Merge branch 'main' into master
ramsey Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/UuidBinaryOrderedTimeType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

namespace Ramsey\Uuid\Doctrine;

use Doctrine\DBAL\ParameterType;
Copy link
Sponsor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall fine to have this patch, but then we need to bump the minimum supported doctrine/dbal to ^3.

use InvalidArgumentException;
use Ramsey\Uuid\Codec\OrderedTimeCodec;
use Doctrine\DBAL\Types\ConversionException;
Expand Down Expand Up @@ -229,4 +230,14 @@ private function decode($bytes)

return $decoded;
}

/**
* @inheritdoc
*
* @return int
*/
public function getBindingType()
{
return ParameterType::BINARY;
}
}
5 changes: 5 additions & 0 deletions tests/UuidBinaryOrderedTimeTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,11 @@ public function testRequiresSQLCommentHint()
$this->assertTrue($this->getType()->requiresSQLCommentHint($this->getPlatform()));
}

public function testItReturnsAppropriateBindingType()
{
$this->assertEquals(16, $this->getType()->getBindingType());
}

/**
* @return AbstractPlatform & MockInterface
*/
Expand Down