Serialization should not use internal codec #361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #318 is the root cause of issues #329 and ramsey/uuid-doctrine#152. This PR should fix that.
Description
The problem is, that call to
getBytes
and subsequentlythis->codec->encodeBytes
returns invalid result when UUID is used withOrderedTimeCodec
. When this combination is used, current master returns binary string with shuffled values (as OrderedTimeCodec does) and deserialization later returns invalid instance of UUID. Then new code is same as wouldStringCodec
do.Motivation and context
Fixed #329 and ramsey/uuid-doctrine#152
How has this been tested?
Unit test included
Types of changes
Checklist:
composer run-script test
locally, and there were no failures or errors. (I have, some fail, but unrelated to the issue)