Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature proposal for ticker.calendar #1726

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

rickturner2001
Copy link
Contributor

This is a clearner implementation regarding #1712

@@ -559,7 +563,7 @@ def __init__(self, data: TickerData, proxy=None):
self._retired_info = None
self._sustainability = None
self._recommendations = None
self._calendar = None
self._calendar = CalendarData(data.ticker)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass through data object, use that for web requests.

@ValueRaider
Copy link
Collaborator

ValueRaider commented Oct 18, 2023

I'm basically black-box-testing your calendar and struggling. Look below, one is easier than the other.

print(dat.calendar)

<yfinance.scrapers.quote.CalendarData object at 0x7fa894e794d0>

?

print(dat.earnings_dates)

                           EPS Estimate  Reported EPS  Surprise(%)
Earnings Date                                                     
...
2023-10-26 16:00:00-04:00          0.58           NaN          NaN
2023-08-03 12:00:00-04:00          0.35          0.65       0.8573
...

nice

Maybe write some documentation? Or something like this:

return "lazy-loading dict with keys = " + str(self.keys())

@rickturner2001
Copy link
Contributor Author

@ValueRaider Is calendar essentially doing the same as earnings_dates?

@ValueRaider
Copy link
Collaborator

Essentially yes but subtle difference. calendar would return this when week known but not day (AMZN):

Earnings Date | Jan 31, 2024 - Feb 05, 2024

earnings_dates just returns Jan 31

@ValueRaider
Copy link
Collaborator

ValueRaider commented Jan 21, 2024

FYI Ticker.calendar has been implemented here #1790, as it used to be before the encryption mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants