Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make npm run dev fast again. #51

Closed
mook-as opened this issue Jan 8, 2021 · 1 comment · Fixed by #57
Closed

Make npm run dev fast again. #51

mook-as opened this issue Jan 8, 2021 · 1 comment · Fixed by #57
Assignees
@mook-as
Labels
kind/enhancement New feature or request
Projects
Stripey

Comments

@mook-as
Copy link
Contributor

mook-as commented Jan 8, 2021

#34 seems to have made npm run dev a bit slower; we should try to see if we can speed it up a bit to make development easier.
@mook-as mook-as added the kind/enhancement New feature or request label Jan 8, 2021
@gaktive gaktive added this to To do in Stripey Jan 8, 2021
@mook-as
Copy link
Contributor Author

mook-as commented Jan 12, 2021

Previously, we were running electron background.js directly (i.e. no compilation time); now that we're pulling in things like class-private members we need it. Currently I'm seeing ~50s from starting npm run dev to preferences window showing up. It used to be closer to ~8s.

@mook-as mook-as mentioned this issue Jan 12, 2021
Merged
@mook-as mook-as self-assigned this Jan 12, 2021
@mook-as mook-as moved this from To do to Review in Stripey Jan 12, 2021
@mook-as mook-as moved this from Review to Done in Stripey Jan 14, 2021
jandubois pushed a commit to jandubois/rancher-desktop that referenced this issue Jun 28, 2024
@Nino-K
Merge pull request rancher-sandbox#51 from mook-as/shutdown-on-context
9e6d3ff 
Try to ensure that we exit when the context is closed
jandubois pushed a commit to jandubois/rancher-desktop that referenced this issue Jun 28, 2024
@Nino-K
Merge pull request rancher-sandbox#51 from mook-as/shutdown-on-context
92ff063 
Try to ensure that we exit when the context is closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mook-as mook-as

Labels
kind/enhancement New feature or request
Projects
No open projects
Stripey
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve npm run dev speed mook-as/rd
1 participant
@mook-as