Packaging for macOS using electron-builder #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
To note my 2 issues when testing...
|
This is needed for other tools.
This will be used to package things up.
This is necessary because the provided one doesn't seem to do the correct thing with packaged mode.
It leads to webpack not packaging dependencies (because it didn't see them)
Because some tools appear to expect NDOE_ENV to be "development" instead of "DEV".
Just seems like better packaging.
That does everything needed; running electron manually leads to errors loading files. Also drops the "concurrently" package, since we no longer use it.
This is required for packaged builds.
Otherwise the tray icon & the minikube executable will be missing.
This ensures it gets picked up correctly when we do packaged builds.
This is necessary as the renderer process would not have access to the electron.app object (required to see if the application is packaged).
mook-as
force-pushed
the
packaging-macos-electron-builder
branch
from
009b56d
to
4c4b6a6
Compare
Otherwise we will not be able to find it in packaged builds.
|
Fixed issue 1) (because we were failing to load the versions JSON); still unclear what 2) was from. But that should be independent of this PR, to be fixed in #31. |
mattfarina
approved these changes
Jan 7, 2021
jandubois
pushed a commit
to jandubois/rancher-desktop
that referenced
this pull request
Jun 28, 2024
Ignore unused ctx
jandubois
pushed a commit
to jandubois/rancher-desktop
that referenced
this pull request
Jun 28, 2024
Ignore unused ctx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #28 using electron-builder instead. This would also fix #9.
Running it for development is the same as before, using
npm run dev.Building the package will now be
npm run electron:build.Note that this will also not resolve issues around installing
hyperkitas mentioned in #28.