Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-v2.8] Fix rancher-monitoring error: undefined variable "$forceHTTPSScheme" #3785

Merged
merged 2 commits into from
Apr 12, 2024
Merged

[dev-v2.8] Fix rancher-monitoring error: undefined variable "$forceHTTPSScheme" #3785

merged 2 commits into from
Apr 12, 2024

Conversation

joshmeranda
Copy link
Contributor

@joshmeranda joshmeranda commented Apr 12, 2024 •
edited
Loading

Issue:

rancher/rancher#45119

Problem

Solution

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

@joshmeranda joshmeranda requested a review from a team as a code owner April 12, 2024 17:17
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

ericpromislow
ericpromislow approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshmeranda joshmeranda merged commit af2a8a2 into rancher:dev-v2.8 Apr 12, 2024
7 checks passed
@ericpromislow ericpromislow mentioned this pull request Apr 12, 2024
Closed
lucasmlp pushed a commit that referenced this pull request May 8, 2024
@joshmeranda @lucasmlp
[dev-v2.8] Fix rancher-monitoring error: undefined variable "$forceHT…
e5633ab 
…TPSScheme" (#3785)

Co-authored-by: joshmeranda <joshua.meranda@gmail.com>
@lucasmlp lucasmlp mentioned this pull request May 8, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpromislow ericpromislow ericpromislow approved these changes

@alexandreLamarre alexandreLamarre alexandreLamarre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshmeranda @ericpromislow @alexandreLamarre