Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.9] Csp adapter release v4.0.0 rc1 #3875

Merged
merged 2 commits into from
May 9, 2024

Conversation

mbelur
Copy link
Contributor

@mbelur mbelur commented May 7, 2024

##Issue:
rancher/rancher#43856

##Problem:
Create new rancher-csp-adapter chart for 2.9 rancher

##Testing:

scenario 1 (fresh install):

On an EKS cluster (k8s version 1.27), install locally built rancher with cspAdapterMinVersion: 104.0.0+up4.0.0-rc1
Validated the support config and licence entitlement functionality. Created a downstream EKS cluster with 21 nodes (with 1 entitlement) to trigger out-of-compliance message. Scaled down the cluster to 17 nodes, validated that the out-of-compliance message is no longer displayed. Scaled back up to 21 nodes, validated the out-of-compliance message popped up.

scenario 2 (upgrade scenario):

Start with an EKS cluster (k8s version 1.27), install rancher 2.8.3 with csp-adapter 3.0.1
Upgrade rancher to locally built rancher with cspAdapterMinVersion: 104.0.0+up4.0.0-rc1
Update charts url repo/branch and upgrade csp-adapter version to 104.0.0+up4.0.0-rc1
Validated the support config and licence entitlement functionality. Created a downstream EKS cluster with 21 nodes (with 1 entitlement) to trigger out-of-compliance message. Scaled down the cluster to 17 nodes, validated that the out-of-compliance message is no longer displayed. Scaled back up to 21 nodes, validated the out-of-compliance message popped up.

@mbelur mbelur requested a review from a team as a code owner May 7, 2024 21:34
Copy link

github-actions bot commented May 7, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@lucasmlp lucasmlp changed the title Csp adapter release v4.0.0 rc1 [dev-v2.9] Csp adapter release v4.0.0 rc1 May 8, 2024
@mbelur mbelur force-pushed the csp-adapter-release-v4.0.0-rc1 branch from d33f190 to 47f123c Compare May 8, 2024 17:12
Copy link

github-actions bot commented May 8, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Copy link

@jeremy-moffitt jeremy-moffitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and consistent with the previous versions. Will want to get a review from @gbuenodevsuse as well before merging. thanks!

Copy link

@gbuenodevsuse gbuenodevsuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbelur mbelur merged commit e2a189d into rancher:dev-v2.9 May 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants