Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete branching steps for Rancher 2.9 for CSP Adapter #43856

Closed
3 tasks done
Tracked by #43831
rohitsakala opened this issue Dec 21, 2023 · 6 comments
Closed
3 tasks done
Tracked by #43831

Complete branching steps for Rancher 2.9 for CSP Adapter #43856

rohitsakala opened this issue Dec 21, 2023 · 6 comments
Assignees
Labels
kind/enhancement Issues that improve or augment existing functionality team/socket

Comments

@rohitsakala
Copy link
Member

rohitsakala commented Dec 21, 2023

Tasks

  • change the rancher-version annotation to catalog.cattle.io/rancher-version: '>= 2.9.0-0 < 2.10.0-0' while adding charts to dev-v2.9 branch. We do this so we can add patches to a particular Rancher minor version, in this case, it would be the Rancher 2.9 line.
  • must have a new chart inside the rancher/charts repository that has a version 104.0.0+upX.Y.Z instead of 103.x.x+upX.Y.Z.
  • testing
@rohitsakala rohitsakala added the kind/enhancement Issues that improve or augment existing functionality label Dec 21, 2023
@cbron cbron assigned jeremy-moffitt and unassigned cbron Dec 27, 2023
@jeremy-moffitt
Copy link

@guangyee please take a look at this when you're back next week.

@jeremy-moffitt
Copy link

my understanding from talking to Guang and Charu is that we need rancher/csp-adapter#76 to land first, which is dependent upon rancher/client-go#7

@jeremy-moffitt
Copy link

@guangyee I see the branch has been created, whats the status of the charts, annotations, and testing?

@guangyee
Copy link
Contributor

release/v2.9 branch had been created. We'll need to re-target this PR to the new branch and get it reviewed and merged.
rancher/csp-adapter#76

@guangyee
Copy link
Contributor

With rancher/csp-adapter#78, we've completed local chart changes to support Rancher v2.9. Next step is to make the changes in rancher/charts and perform integration testing.

mbelur added a commit to mbelur/charts that referenced this issue May 1, 2024
@jeremy-moffitt
Copy link

Meera indicates the work is complete with the PRs that merged today, closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues that improve or augment existing functionality team/socket
Projects
None yet
Development

No branches or pull requests

4 participants