Update fleet grafana dashboards #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
thehejik
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
I checked all 5 modified Grafana dashboards for Fleet and they are showing reasonable data. Also Prometheus Targets and Prometheus Graph are working as expected for fleet resources.
I was playing a bit with creating Fleet ClusterGroups and assigning various clusters there together with using filters in Grafana, all good.
mallardduck
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
@p-se - looks pretty good to me overall. The PR is out of date with the HEAD, so other than updating for that before merge LGTM. (Edit - weird after I submitted the review it stopped showing the outdated branch thing)
|
@thehejik @mallardduck |
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
krunalhinguu
pushed a commit
to krunalhinguu/charts
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
rancher/fleet#2460
Problem
For the existing Fleet metrics (and Prometheus configuration to scrape those), Grafana dashboards have recently been added. They were pretty raw and barely usable. This PR updates them (see screenshots at the bottom).
Solution
Update Grafana dashboards for visualizing Fleet metrics.
Testing
Engineering Testing
Manual Testing
See Testing.
Automated Testing
Testing up to fetching and testing metrics from fleet-controller in https://github.com/rancher/fleet/tree/main/e2e/metrics. It does not cover the use of the ServiceMonitor to configure the Prometheus instance to scrape those metrics nor anything with Grafana.
QA Testing Considerations
No additional testing required, tests as described in the Testing section are deemed sufficient.
Regressions Considerations
I cannot think of any cases in which updating (not yet shipped) Grafana dashboards would conflict with existing dashboards.
Backporting considerations
Does not need to be backported.
Screenshots