Add Grafana dashboard for Fleet performance #4106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
1 similar comment
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
thehejik
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Test report
Verified on rancher v2.9-head v2.9-d68a9b4627050b3f2bbe5a8e4cbca1ec7df82200-head with fleet:104.0.0+up0.10.0-rc.16 and rancher-monitoring:104.0.0-rc1+up45.31.1
There is a new dashboard named Fleet / Controller-Runtime:
The other fleet dashboards are outdated as #4091 is not merged yet.
alexandreLamarre
approved these changes
Jun 20, 2024
alexandreLamarre
approved these changes
Jun 20, 2024
This dashboard utilizes generic metrics available by just using controller-runtime and enables insights into the performance of Fleet controllers. Related to rancher/fleet#2460
p-se
force-pushed
the
add-fleet-controller-runtime-dashboard
branch
from
c97210d
to
0749777
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
|
After rebase the new dashboard is still working and the other fleet dashboards were updated. |
krunalhinguu
pushed a commit
to krunalhinguu/charts
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Partly implements rancher/fleet#2460
Shares parent issue with #4091
Problem
This dashboard utilizes generic metrics available by just using controller-runtime and enables insights into the performance of Fleet controllers.
Solution
Testing
Imported the dashboard into a Grafana instance installed by
rancher-monitoring(from dev-v2.9 branch to contain the necessary ServiceMonitor custom resource) chart using Rancher 2.9. Metrics in Fleet are available since v0.10.0-rc.13.Engineering Testing
Manual Testing
See Testing.
Automated Testing
No automated tests for this dashboard.
QA Testing Considerations
Regressions Considerations
New dashboard, no regressions possible.
Backporting considerations
Does not need to be backported.