Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS out-of-tree examples #334

Merged
merged 1 commit into from
May 28, 2024

Conversation

alexander-demicev
Copy link
Member

@alexander-demicev alexander-demicev commented May 21, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #329

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

salasberryfin
salasberryfin previously approved these changes May 21, 2024
cni: calico
cloudProviderName: external
agentConfig:
airGapped: true
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question - are we sure that AWS will always have to be airGapped? This forces us to release new AWS AMI with each released version, if I understand it correctly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, we will not remove non-airgapped option from supported for feature parity with CAPR. I added airgapped to these examples to start educating users to get used to the current CAPI model where dependencies are baked into the image.
We are also not going to publish AMIs for each release, there is a section in the docs asking users to do it themselves, and there are some limitations currently in the packer flow that won't allow us to easily build and publish AMIs for community users. Someone has to upload the base image to S3 bucket in all AWS regions where we want it supported and then build CAPI images on top of that, and for production cases, there is no good way to verify where the image comes from. We might consider something like elemental-toolkit in future rancher/elemental-toolkit#1978 to make image building easier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally like the idea of using elemental-toolkit for something. I agree it makes sense to explore process in more details and see how their image building solution may aid us in our scenarios.

Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
@alexander-demicev alexander-demicev merged commit 65761c1 into rancher:main May 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update AWS out-of-tree examples
3 participants