Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 1.28 k8s version #76

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Bump to 1.28 k8s version #76

merged 1 commit into from
Jan 31, 2024

Conversation

chajain
Copy link

@chajain chajain commented Jan 4, 2024

No description provided.

@chajain
Copy link
Author

chajain commented Jan 4, 2024

@MbolotSuse The ci-build is failing with error

go: downloading github.com/josharian/intern v1.0.0

k8s.io/client-go/applyconfigurations/meta/v1

/go/pkg/mod/github.com/rancher/client-go@v1.27.4-rancher1/applyconfigurations/meta/v1/unstructured.go:64:38: cannot use doc (variable of type *"github.com/google/gnostic/openapiv2".Document) as *"github.com/google/gnostic-models/openapiv2".Document value in argument to proto.NewOpenAPIData
time="2024-01-04T02:06:31Z" level=fatal msg="exit status 1"

I am guessing that I also need to update the client-go version in https://github.com/rancher/csp-adapter/pull/76/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L13 but the PR for that is still in WIP rancher/client-go#7 .

Copy link
Contributor

@guangyee guangyee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@MbolotSuse
Copy link
Contributor

@chajain Looks like the CI is failing due to the adapter failing to build. You will need to update the client-go version as well. I would recommend putting this PR on hold until that work is complete.

@MbolotSuse MbolotSuse removed the request for review from rmweir January 8, 2024 21:48
go.mod Outdated Show resolved Hide resolved
@chajain chajain changed the base branch from release/v2.8 to release/v2.9 January 30, 2024 17:48
@guangyee guangyee merged commit bd14e67 into rancher:release/v2.9 Jan 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants