-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFE] Add deprecation warning on SRIOV chart in UI #11042
Comments
@mgfritch FYI |
Proposed copy:
This may require a corresponding ticket in https://github.com/rancher/docs but putting |
I have tested today and the upgrade is pretty painless if you use the same name to install the chart coming from the edge repo. As it does a
|
@gaktive @manuelbuil I created rancher/rancher-docs#1297 for the docs portion. We can move docs-specific discussion there. |
Perhaps an annotation on the chart would help out here since having custom deprecation warnings for each chart will not be scalable. Assigning to @nwmac only to figure out a strategy but someone else can work on this. |
@manuelbuil My suggestion would be: Add support for a new chart annotation When present, the UI will show that the chart is deprecated (this will be shown in the same place as we show 'Experimental' and would take precedence, so we only show one or the other). When present, we would also show a deprecation notice on the chart details page. |
Sounds like a good idea |
Dev will sync with @kwwii on some of the design to visualize a chart to not use. This lives in Apps & Marketplace |
Deprecate the sriov chart from the `rancher/charts` repo: - Add helm chart deprecation warning - Add rancher `catalog.cattle.io/deprecated` annotation The replacement chart can be found here: - https://github.com/suse-edge/charts Issue: rancher/dashboard#11042 Signed-off-by: Michael Fritch <mfritch@suse.com>
- Add helm chart deprecation warning - Add rancher `catalog.cattle.io/deprecated` annotation - Future chart updates can be found here: https://github.com/suse-edge/charts Issue: rancher/dashboard#11042 Signed-off-by: Michael Fritch <mfritch@suse.com>
I added this new annotation while deprecating rancher sriov chart (rancher/charts#4025). And I also set the helm However, I'm wondering if we really need to add the additional rancher |
@manuelbuil @mgfritch @momesgin Yes - good idea - we can read the |
@nwmac As I have discovered so far, once the But in the chart's details page we don't even make the request to get a deprecated chart's data, I'm not sure why exactly this happens, and it's not just Sriov, I also found another chart called Sysdig with the same situation. Another concern that I have is about the proposed copy:
it's a very specific warning message for Sriov, but the UI should display a generic message for all deprecated charts with some dynamic fields like the chart's name, e.g. |
@momesgin Okay - so that logic for deprecated charts must be somewhere in the UI code - I'd suggest we always show deprecated charts - or maybe we need to check with @kwwii on having a checkbox for this. That text is specific - the chart should include that in its readme - we will not use that text in the UI - we should only show a generic banner saying that the chart is deprecated. |
e2e tests are sufficient. moving to done |
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
SRIOV charts will no longer be updated in https://github.com/rancher/charts because their new home is https://github.com/suse-edge/charts. If a user wants to consume SRIOV chart, that user will need to include the new helm repo in Rancher. Currently, the chart is in sync in both repos.
For the v2.9 release, charts will continue to be in both helm repos. For the v2.10 release we expect the chart to not be available via Rancher default charts Therefore, it would be nice to add a deprecation warning in v2.9 so that users are aware of the situation and know what is the way forward.
Describe the solution you'd like
A clear and concise description of what you want to happen.
I would like to add a warning in the UI so that users picking SRIOV chart know that it is deprecated and that it will be removed in the v2.10 cycle
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: