Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values for non-Rancher apps are not present in the API request when installing/upgrading #1221

Closed
bmdepesa opened this issue Sep 10, 2020 · 1 comment
Assignees
Milestone

Comments

@bmdepesa
Copy link
Member

rancher/rancher:master-head 198ec5b

  • Deploy a cluster and navigate to dashboard apps
  • Select a non-Rancher app to deploy (partner chart or add your own repo)
  • When installing the app, change some values
    • Select the haproxy partner chart, and in Settings change the deployment type to Daemonset and service type to Load Balancer
  • Install the app
  • The values are not set in the request, and the app deploys with default settings
{
  "charts": [
    {
      "chartName": "haproxy",
      "version": "1.4.300",
      "releaseName": "haproxy",
      "namespace": "haproxy",
      "values": {
        "global": {
          "cattle": {
            "clusterId": "c-p7dtq",
            "clusterName": "test-52296",
            "systemDefaultRegistry": ""
          }
        },
        "systemDefaultRegistry": ""
      }
    }
  ],
  "noHooks": false,
  "timeout": "600s",
  "wait": true,
  "disableOpenAPIValidation": false,
  "skipCRDs": false
}
  • The same behavior occurs on upgrading, though in case of upgrades, the Version is set correctly
@bmdepesa bmdepesa added this to the v2.5 milestone Sep 10, 2020
@bmdepesa bmdepesa self-assigned this Sep 10, 2020
vincent99 added a commit to vincent99/dashboard that referenced this issue Sep 11, 2020
vincent99 added a commit that referenced this issue Sep 11, 2020
Fix question charts saving to values (#1221)
@bmdepesa
Copy link
Member Author

rancher/rancher:master-head 31d7ad3

  • Values are now being set in the API request and can be seen in helm values
{
  "charts": [
    {
      "chartName": "docker-registry",
      "version": "1.9.2",
      "releaseName": "dr6",
      "namespace": "default",
      "values": {
        "service": {
          "type": "NodePort",
          "nodePort": 30004
        },
        "global": {
          "cattle": {
            "clusterId": "local",
            "clusterName": "local",
            "systemDefaultRegistry": ""
          }
        },
        "systemDefaultRegistry": ""
      }
    }
  ],
  "noHooks": false,
  "timeout": "600s",
  "wait": true,
  "disableOpenAPIValidation": false,
  "skipCRDs": false
}

Screen Shot 2020-09-11 at 4 02 18 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants