Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple Alerting Rules in PrometheusRule to always display the same value #9926

Open
kingsd041 opened this issue Oct 16, 2023 · 2 comments · Fixed by #9927 or #10745
Open

Add multiple Alerting Rules in PrometheusRule to always display the same value #9926

kingsd041 opened this issue Oct 16, 2023 · 2 comments · Fixed by #9927 or #10745
Assignees
@torchiaf
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone
v2.9.0

Comments

@kingsd041
Copy link

Setup

  • Rancher version: v2.7.8
  • Rancher UI Extensions:
  • Browser type & version:

Describe the bug

When adding a second or more Alerting Rules to a PrometheusRule, the newly added Alerting Rules are the same as the first one

To Reproduce

  1. Enable rancher monitoring, navigate to PrometheusRule and add multiple Alerting Rules
    Result
    All Alerting Rules are the same, and if you modify one of the Alerting Rules, the other forms will also take effect.

Screenshots

Additional context

prometheus
@ly5156 ly5156 mentioned this issue Oct 16, 2023
Merged
@richard-cox richard-cox added this to the v2.8.next1 milestone Oct 16, 2023
@github-actions github-actions bot reopened this Nov 24, 2023
@nwmac nwmac added the QA/manual-test Indicates issue requires manually testing label Jan 30, 2024
@nwmac nwmac added the automation-candidate Candidate for being covered by automated tests label Mar 4, 2024
aalves08 added a commit to aalves08/dashboard that referenced this issue Apr 3, 2024
@aalves08
add e2e tests for rancher#10389 and rancher#9926
ef3fdb1
@aalves08 aalves08 mentioned this issue Apr 3, 2024
Merged
7 tasks
aalves08 added a commit to aalves08/dashboard that referenced this issue Apr 4, 2024
@aalves08
add e2e tests for rancher#10389 and rancher#9926
be2d856
aalves08 added a commit that referenced this issue Apr 10, 2024
@aalves08
add e2e tests for #10389 and #9926 (#10745)
764fa60 
* add e2e tests for #10389 and #9926

* disable eslint for massive blueprint schema file

* fix e2e test issue + sneaky improvement for carousel unit test

* uncomment missing e2e test

* simplify schemas data and logic to generate a V2 monitoring on a local cluster for e2e tests

* minor code cleanup
@github-actions github-actions bot reopened this Apr 10, 2024
@zube zube bot removed the [zube]: Done label Apr 10, 2024
@aalves08 aalves08 added QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this [zube]: QA Review and removed [zube]: To Triage QA/manual-test Indicates issue requires manually testing automation-candidate Candidate for being covered by automated tests labels Apr 10, 2024
@github-actions github-actions bot added [zube]: To Test QA/manual-test Indicates issue requires manually testing automation-candidate Candidate for being covered by automated tests and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this [zube]: QA Review labels Apr 10, 2024
@aalves08 aalves08 removed the automation-candidate Candidate for being covered by automated tests label Apr 10, 2024
@nwmac nwmac added QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this and removed [zube]: To Test QA/manual-test Indicates issue requires manually testing labels Apr 10, 2024
@nwmac
Copy link
Member

nwmac commented Apr 10, 2024

automated e2e tests added with this PR: #10745

@yonasberhe23
Copy link
Contributor

e2e test seems sufficient to me. Moving this to Done cc: @izaac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torchiaf torchiaf

Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Milestone
v2.9.0
7 participants
@nwmac @gaktive @richard-cox @kingsd041 @torchiaf @aalves08 @yonasberhe23