Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e tests for #10389 and #9926 #10745

Merged
merged 6 commits into from Apr 10, 2024

Conversation

aalves08
Copy link
Contributor

@aalves08 aalves08 commented Apr 3, 2024

Summary

Fixes #10389
Fixes #9926

Occurred changes and/or fixed issues

  • Adds e2e tests for v2 monitoring
  • sneaky fix for a unit test with Carousel component to improve assertion quality

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 added this to the v2.9.0 milestone Apr 3, 2024
@aalves08 aalves08 self-assigned this Apr 3, 2024
@aalves08
Copy link
Contributor Author

aalves08 commented Apr 4, 2024

FYI @richard-cox

like other PR's, if this goes in, we can remove the label automation-candidate and remove the label QA-manual-test from both issues

@aalves08 aalves08 removed the request for review from nwmac April 5, 2024 14:46
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aalves08 aalves08 merged commit 764fa60 into rancher:master Apr 10, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants