Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vGpus field in Harvester clusters provision #10657

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

torchiaf
Copy link
Member

@torchiaf torchiaf commented Mar 20, 2024

Summary

Fixes #10588

Occurred changes and/or fixed issues

We are adding the possibility to select a list of vGpus to assign to Harvester clusters. The list of available vGpus needs to be enabled in Harvester first.

Technical notes summary

It will also fix a bug in ArrayListSelect component when emitting new input event.

Areas or cases that should be tested

harvester.vue component

Areas which could experience regressions

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@torchiaf torchiaf force-pushed the 10588-harvester-vgpus branch 2 times, most recently from daf1099 to 0737469 Compare March 25, 2024 18:50
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf added QA/manual-test Indicates issue requires manually testing area/harvester area/rke2 kind/enhancement labels Apr 18, 2024
@torchiaf torchiaf added this to the v2.9.0 milestone Apr 18, 2024
@torchiaf torchiaf marked this pull request as ready for review April 18, 2024 11:10
@torchiaf torchiaf changed the title VGpus integration Harvester - VGpu integration Apr 18, 2024
@torchiaf torchiaf changed the title Harvester - VGpu integration Harvester - vGpu integration Apr 18, 2024
@torchiaf torchiaf removed area/harvester area/rke2 kind/enhancement QA/manual-test Indicates issue requires manually testing labels Apr 18, 2024
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf changed the title Harvester - vGpu integration Add vGpus field in Harvester clusters provision Apr 18, 2024
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf merged commit 2c6711b into rancher:master Apr 22, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: allow allocation of vGPU resources for Harvester
2 participants