-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automation: rke1 cluster prov azure #10715
automation: rke1 cluster prov azure #10715
Conversation
7bc7d65
to
18c015b
Compare
19a701f
to
1d6cb13
Compare
1d6cb13
to
f8c846d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small request for a big comment, otherwise looks good
cy.login(); | ||
HomePagePo.goTo(); | ||
|
||
// clean up azure node templates and cloud credentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nitpicky request, could this and below be made very prominent, just in case someone runs this locally and finds their test cluster changed? maybe something at the top of the file like below
/******
* Running this test will delete x and y resources from the target cluster
******/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call!
f8c846d
to
a046b78
Compare
a046b78
to
185ba58
Compare
Summary
Fixes #
rancher/qa-tasks#1234
Technical notes summary
bugs that cause this test to fail:
Checklist