Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automation: rke1 cluster prov azure #10715

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

yonasberhe23
Copy link
Contributor

Summary

Fixes #
rancher/qa-tasks#1234

Technical notes summary

bugs that cause this test to fail:

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small request for a big comment, otherwise looks good

cy.login();
HomePagePo.goTo();

// clean up azure node templates and cloud credentials
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nitpicky request, could this and below be made very prominent, just in case someone runs this locally and finds their test cluster changed? maybe something at the top of the file like below

/******
 *  Running this test will delete x and y resources from the target cluster
 ******/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call!

@yonasberhe23 yonasberhe23 merged commit 9a1a4b6 into rancher:master Apr 22, 2024
25 checks passed
@yonasberhe23 yonasberhe23 deleted the rke1_cluster_prov_azure branch April 22, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants