Default to unlimited line width when dumping yaml blocks #10757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This defaults to unlimited line width when dumping yaml blocks. This should resolve issues where newline characters are inserted into yaml while using the form editor, breaking previously functional manifests.
Fixes #10589
Technical notes summary
I don't see any situation where it would be valid to insert newline characters at the default of 80 characters. If we do want this behavior, that would be the exception and we can supply proper options for a specific field we want to target.
An alternative approach would be to specify a
lineWidth
for individual fields likemetadata.annotations
, but I thought this too specific an approach, and leaves us in a situation where future tickets will open for properties that we haven't considered.Areas or cases that should be tested
Configmaps - See the linked issues for detailed reproduction steps.
Areas which could experience regressions
create-yaml
utilChecklist