Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to unlimited line width when dumping yaml blocks #10757

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Apr 4, 2024

Summary

This defaults to unlimited line width when dumping yaml blocks. This should resolve issues where newline characters are inserted into yaml while using the form editor, breaking previously functional manifests.

Fixes #10589

Technical notes summary

I don't see any situation where it would be valid to insert newline characters at the default of 80 characters. If we do want this behavior, that would be the exception and we can supply proper options for a specific field we want to target.

An alternative approach would be to specify a lineWidth for individual fields like metadata.annotations, but I thought this too specific an approach, and leaves us in a situation where future tickets will open for properties that we haven't considered.

Areas or cases that should be tested

Configmaps - See the linked issues for detailed reproduction steps.

Areas which could experience regressions

  • Configmaps
  • Anything that utilizes the create-yaml util

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rak-phillip rak-phillip added this to the v2.9.0 milestone Apr 4, 2024
@rak-phillip rak-phillip self-assigned this Apr 4, 2024
Copy link
Member

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I found small type issues, not related with current changes: #10775

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rak-phillip rak-phillip merged commit c0b8eaa into rancher:master Apr 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing configmap in rancher adds newline characters breaking kustomize
2 participants