Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type errors in create-yaml.test.ts #10775

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix type errors in create-yaml.test.ts #10775

merged 1 commit into from
Apr 9, 2024

Conversation

torchiaf
Copy link
Contributor

@torchiaf torchiaf commented Apr 9, 2024 •
edited
Loading

Summary

Fixing minor type errors in unit tests.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@torchiaf
Fix type errors in create-yaml.test.ts
6525a5b 
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf added this to the v2.9.0 milestone Apr 9, 2024
@torchiaf torchiaf mentioned this pull request Apr 9, 2024
Merged
7 tasks
rak-phillip
rak-phillip approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - good catch on this one 😁

I don't think I originally received these warnings in my editor, but I definitely see them now.. The errors are resolved with this change.

@torchiaf torchiaf merged commit 6b352c3 into rancher:master Apr 9, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rak-phillip rak-phillip rak-phillip approved these changes

Assignees

@torchiaf torchiaf

Labels
None yet
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@torchiaf @rak-phillip