Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mgmt cluster description to prov cluster description as fallback in home cluster list and main side nav clusters #10782

Merged

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Apr 10, 2024

Summary

Fixes #10441 (based on reopening from QA by comment #10441 (comment))

Occurred changes and/or fixed issues

  • add mgmt cluster description to prov cluster description as fallback in home cluster list and main side nav clusters

Technical notes summary

Descriptions were not appearing because both lists are based on CAPI clusters and the ones mentioned by QA are MGMT clusters. Added the MGMT clusters to the home cluster list and main side nav clusters

Areas or cases that should be tested

  • Edit local cluster and add a description
  • Provision a AKS, EKS or GKE cluster with a description
  • make sure description appears in the home page cluster list and main side nav clusters

Areas which could experience regressions

Screenshot/Video

Screenshot 2024-04-10 at 16 20 33
Screenshot 2024-04-10 at 16 27 26

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

… in home cluster list and main side nav clusters
@aalves08 aalves08 requested a review from momesgin April 19, 2024 09:07
@aalves08 aalves08 requested a review from momesgin April 19, 2024 17:17
Copy link
Member

@momesgin momesgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with an AKS cluster and LGTM

@aalves08
Copy link
Member Author

@izaac @yonasberhe23 I've added some coverage for this under the RKE1 amazon EC2 cluster provisioning. I did my best to test this fully but it needs a remote instance (couldn't test against this branch env) so the only I didn't test was reading the description from the home page cluster list, but that has been covered previously so I don't think it will put us into any problems. Just for FYI if you notice anything weird (Idk if this test in particular runs on our pipeline or not). 🙏

@aalves08 aalves08 merged commit 7be2f2e into rancher:master Apr 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cluster description to cluster side menu and main menu
2 participants