Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e test for issue 9800 #10918

Merged
merged 2 commits into from
May 7, 2024
Merged

Conversation

aalves08
Copy link
Contributor

Summary

Fixes #9800 (e2e testing)

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 self-assigned this Apr 30, 2024
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.9.0 milestone Apr 30, 2024
eva-vashkevich
eva-vashkevich previously approved these changes May 1, 2024
cypress/e2e/tests/pages/users-and-auth/roles.spec.ts Outdated Show resolved Hide resolved
Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aalves08 aalves08 merged commit ec29620 into rancher:master May 7, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public API [kubectl/v1] Dashboard Incorrectly Showing GlobalRole as Builtin When It's Not
2 participants