Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automation: add check for architecture column #10922

Merged
merged 1 commit into from
Jun 14, 2024
Merged

automation: add check for architecture column #10922

merged 1 commit into from
Jun 14, 2024

Conversation

yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented May 1, 2024 •
edited by nwmac
Loading

Summary

Fixes #10831

add check for the architecture column in existing e2e tests RKE1/RKE2 cluster provisioning

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@yonasberhe23 yonasberhe23 added this to the v2.9.0 milestone May 1, 2024
@yonasberhe23 yonasberhe23 requested a review from izaac May 1, 2024 00:31
@yonasberhe23 yonasberhe23 self-assigned this May 1, 2024
@yonasberhe23 yonasberhe23 changed the title add check for architecture column automation: add check for architecture column May 1, 2024
@nwmac nwmac mentioned this pull request May 1, 2024
Merged
izaac
izaac approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonasberhe23 yonasberhe23 marked this pull request as draft May 16, 2024 17:44
izaac
izaac approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonasberhe23 yonasberhe23 marked this pull request as ready for review June 13, 2024 18:20
@yonasberhe23 yonasberhe23 merged commit 0483d18 into rancher:master Jun 14, 2024
26 checks passed
@yonasberhe23 yonasberhe23 deleted the architecture_column_test branch June 14, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaac izaac izaac approved these changes

Assignees

@yonasberhe23 yonasberhe23

Labels
None yet
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.

Architecture column shows 'Mixed' when cluster is provisioning
2 participants
@yonasberhe23 @izaac