GH Project Workflow: Handle case where issue number is empty in 'Fixes' notation #10925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwmac
changed the title
nwmac
changed the title
|
I hit something similar with #10761 and had to catch an exception instead, plus two other tweaks were needed (https://github.com/rancher/dashboard/pull/10761/files#diff-674cd4244c5f71d475138dd411bb5959bac74710742c60a2e8c5363f999db827). Shall we iterate with this solution, maybe those tweaks aren't needed now? |
richard-cox
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small tweak to the GH Project workflow when parsing, looking for the fixes notation, to ensure an empty reference or an invalid reference is ignored (e.g. #10922 and #10921)
We check that the extracted issue number can be parsed as an integer and only use it, if it can.