Only logout if the user is logged in #10929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This prevents us from redirecting multiple times when visiting the index on login
Fixes #10926
Technical notes summary
There is still a case on the logout page that we need to be able to call logout even if the user hasn't been authenticated yet because the auth pages don't use the authenticated middleware.
This caused issues with the login page in a roundabout way.
This change will also reduce the unnecessary timeout redirect we would previously see when visiting the index page.
Areas or cases that should be tested
Logging in and logging out
Checklist