[INT] Refactored some of the plugins #10943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rak-phillip
reviewed
May 3, 2024
shell/plugins/global-formatters.js
Outdated
Comment on lines
22
to
24
| console.warn('The implicit addition of global formatters has been deprecated in Rancher Shell and will be removed in a future version. Make sure to invoke `Vue.use(globalFormatters)` to maintain compatibility.'); | ||
|
|
||
| Vue.use(globalFormatters); |
There was a problem hiding this comment.
It looks like we might only require these lines when running tests. Can we update this to use the same pattern as what we use in the i18n plugin now?
rak-phillip
reviewed
May 3, 2024
shell/plugins/global-formatters.js
Outdated
| @@ -1,10 +1,24 @@ | |||
| import Vue from 'vue'; | |||
| /* eslint-disable no-console */ | |||
| import Vue from 'vue';const components = require.context('@shell/components/formatter', false, /[A-Z]\w+\.(vue)$/); | |||
There was a problem hiding this comment.
Did eslint incorrectly munge this line?
7 tasks
rak-phillip
previously approved these changes
May 3, 2024
Co-authored-by: Phillip Rak <rak.phillip@gmail.com>
rak-phillip
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10774
Refactors:
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
The entire application is affected since these plugins are globally used.
In particular:
Areas which could experience regressions
The entire application is affected since these plugins are globally used.
Screenshot/Video
Checklist