Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8] Limit number of assigned vGPUs to 1 for each Machine Pool #10994

Merged
merged 2 commits into from
May 9, 2024

Conversation

torchiaf
Copy link
Member

@torchiaf torchiaf commented May 9, 2024

Summary

Fixes #10992
Fixes #10993

Occurred changes and/or fixed issues

Technical notes summary

  • It will limit the number of assigned vGPUs to 1 to prevent allocation issues.
  • Label format is revisited.

We will remove the constraint once Harvester will support multiple vGPUs in Rancher provisioning.

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

See #10991

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf added this to the v2.8.next1 milestone May 9, 2024
@torchiaf torchiaf requested a review from rak-phillip May 9, 2024 15:24
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +114 to +116
disableAdd() {
return this.addDisabled;
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: I think it's a little redundant to have a computed prop. Without it, the template would be just as simple and declarative. We already employ this pattern for showAdd and showRemove, so it makes sense to stick with the prevalent pattern.

@torchiaf torchiaf merged commit c8431af into rancher:release-2.8 May 9, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants